Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark QuerySmart contract error as deterministic #1904

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

chipshort
Copy link
Collaborator

We apparently didn't mark this as deterministic in #1804.

@chipshort chipshort requested a review from pinosu June 19, 2024 10:49
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.88%. Comparing base (21b048d) to head (12f8ec5).
Report is 5 commits behind head on main.

Current head 12f8ec5 differs from pull request most recent head 5465e8c

Please upload reports for the commit 5465e8c to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
+ Coverage   54.86%   54.88%   +0.02%     
==========================================
  Files          65       65              
  Lines        9772     9772              
==========================================
+ Hits         5361     5363       +2     
+ Misses       3866     3865       -1     
+ Partials      545      544       -1     
Files Coverage Δ
x/wasm/keeper/keeper.go 78.22% <100.00%> (+0.26%) ⬆️

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

just left a small comment that might make the test more robust

x/wasm/keeper/contract_keeper_test.go Outdated Show resolved Hide resolved
@chipshort chipshort merged commit ff0a43b into main Jun 19, 2024
4 of 8 checks passed
@chipshort chipshort deleted the mark-query-deterministic branch June 19, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants