Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish for go vet #205

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Polish for go vet #205

merged 1 commit into from
Jul 20, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jul 17, 2020

go vet run


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alpe alpe requested a review from ethanfrey as a code owner July 17, 2020 15:13
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files          27       27           
  Lines        2584     2584           
=======================================
  Hits         1853     1853           
  Misses        621      621           
  Partials      110      110           
Impacted Files Coverage Δ
x/wasm/internal/keeper/query_plugins.go 57.71% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774f6d7...d9143bc. Read the comment docs.

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alpe alpe merged commit 46e0189 into master Jul 20, 2020
@alpe alpe deleted the go_vet branch July 20, 2020 08:01
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants