Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cosmwasm 0.11 #272

Merged
merged 10 commits into from
Oct 5, 2020
Merged

Update to cosmwasm 0.11 #272

merged 10 commits into from
Oct 5, 2020

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Oct 4, 2020

Closes #271
Closes #267

Current dep: go-cosmwasm 0.11.0-alpha2

Staking issues: #263, #264, #269 should be addressed in separate PRs on top of this one.

@ethanfrey ethanfrey requested a review from alpe as a code owner October 4, 2020 14:35
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #272 into master will increase coverage by 0.00%.
The diff coverage is 57.69%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #272    +/-   ##
========================================
  Coverage   73.27%   73.27%            
========================================
  Files          27       27            
  Lines        2653     2339   -314     
========================================
- Hits         1944     1714   -230     
+ Misses        595      511    -84     
  Partials      114      114            
Impacted Files Coverage Δ
x/wasm/internal/keeper/query_plugins.go 61.87% <0.00%> (-2.42%) ⬇️
x/wasm/internal/types/types.go 24.00% <0.00%> (+0.31%) ⬆️
x/wasm/internal/keeper/keeper.go 90.30% <100.00%> (-0.85%) ⬇️
x/wasm/internal/keeper/api.go 60.00% <0.00%> (-11.43%) ⬇️
x/wasm/client/utils/utils.go 63.63% <0.00%> (-7.80%) ⬇️
x/wasm/internal/keeper/proposal_handler.go 67.08% <0.00%> (-2.68%) ⬇️
x/wasm/internal/keeper/querier.go 52.50% <0.00%> (-2.47%) ⬇️
x/wasm/internal/keeper/handler_plugin.go 72.67% <0.00%> (-1.77%) ⬇️
lcd_test/helpers.go 74.14% <0.00%> (-1.57%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b650fa7...989830e. Read the comment docs.

Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Except for the double quotes only some nits.

x/wasm/internal/keeper/reflect_test.go Outdated Show resolved Hide resolved
ReflectCustom *Text `json:"reflect_custom,omitempty"`
Owner *struct{} `json:"owner,omitempty"`
Capitalized *Text `json:"capitalized,omitempty""`
Chain *wasmTypes.QueryRequest `json:"chain,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: were is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 are defined in the reflect class. I added the here thinking we may add more tests for them, since I was translating types from rust to go anyway.

type customQueryResponse struct {
Msg string `json:"msg"`
}

// these are the return values from contract -> go depending on type of query
type ownerResponse struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: is this used?

Text string `json:"text"`
}

type chainResponse struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: is this used?

x/wasm/internal/types/types.go Outdated Show resolved Hide resolved
@ethanfrey ethanfrey merged commit 2d9bd47 into master Oct 5, 2020
@ethanfrey ethanfrey deleted the update-cosmwasm-0.11 branch October 5, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set time_nanos in wasmTypes.BlockInfo Remove unused WasmConfig.CacheSize
2 participants