-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to cosmwasm 0.11 #272
Conversation
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
========================================
Coverage 73.27% 73.27%
========================================
Files 27 27
Lines 2653 2339 -314
========================================
- Hits 1944 1714 -230
+ Misses 595 511 -84
Partials 114 114
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Except for the double quotes only some nits.
ReflectCustom *Text `json:"reflect_custom,omitempty"` | ||
Owner *struct{} `json:"owner,omitempty"` | ||
Capitalized *Text `json:"capitalized,omitempty""` | ||
Chain *wasmTypes.QueryRequest `json:"chain,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: were is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 3 are defined in the reflect class. I added the here thinking we may add more tests for them, since I was translating types from rust to go anyway.
type customQueryResponse struct { | ||
Msg string `json:"msg"` | ||
} | ||
|
||
// these are the return values from contract -> go depending on type of query | ||
type ownerResponse struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: is this used?
Text string `json:"text"` | ||
} | ||
|
||
type chainResponse struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: is this used?
Closes #271
Closes #267
Current dep:
go-cosmwasm 0.11.0-alpha2
Staking issues: #263, #264, #269 should be addressed in separate PRs on top of this one.