Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to grpc queries #317

Merged
merged 6 commits into from
Nov 23, 2020
Merged

Add pagination to grpc queries #317

merged 6 commits into from
Nov 23, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 18, 2020

Resolves #242

New:

  • New second index for contracts by code id and creation marker
  • Contract code history elements stored into separate prefix

@CosmWasm CosmWasm deleted a comment from codecov bot Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #317 (6027ded) into master (807956b) will increase coverage by 52.00%.
The diff coverage is 81.16%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #317       +/-   ##
===========================================
+ Coverage   17.67%   69.68%   +52.00%     
===========================================
  Files          35       28        -7     
  Lines       10592     2388     -8204     
===========================================
- Hits         1872     1664      -208     
+ Misses       8606      606     -8000     
- Partials      114      118        +4     
Impacted Files Coverage Δ
x/wasm/internal/types/types.go 23.52% <25.00%> (+1.90%) ⬆️
x/wasm/internal/types/keys.go 58.33% <63.63%> (+58.33%) ⬆️
x/wasm/internal/keeper/querier.go 50.99% <83.07%> (-0.44%) ⬇️
x/wasm/internal/keeper/legacy_querier.go 68.75% <93.54%> (+11.82%) ⬆️
x/wasm/internal/keeper/keeper.go 89.94% <100.00%> (-0.37%) ⬇️
x/wasm/internal/keeper/test_fuzz.go 94.11% <100.00%> (ø)
x/wasm/internal/types/genesis.pb.go
x/wasm/internal/types/msg.pb.go
x/wasm/internal/types/proposal.pb.go

@alpe alpe marked this pull request as ready for review November 19, 2020 12:23
@alpe alpe marked this pull request as draft November 19, 2020 12:24
@alpe alpe marked this pull request as ready for review November 19, 2020 16:07
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff; some thoughs

x/wasm/internal/types/types.proto Outdated Show resolved Hide resolved
x/wasm/internal/types/query.proto Outdated Show resolved Hide resolved
x/wasm/internal/keeper/test_common.go Show resolved Hide resolved
x/wasm/internal/types/keys.go Show resolved Hide resolved
x/wasm/internal/types/query.proto Outdated Show resolved Hide resolved
x/wasm/internal/types/types.go Outdated Show resolved Hide resolved
x/wasm/internal/types/types.go Outdated Show resolved Hide resolved
x/wasm/internal/types/types.proto Show resolved Hide resolved
@alpe alpe merged commit b0b407d into master Nov 23, 2020
@alpe alpe deleted the pagination_242 branch November 23, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stargate: Add pagination support for queries
2 participants