Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle panics in query contract smart #322

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Handle panics in query contract smart #322

merged 1 commit into from
Nov 30, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 24, 2020

Resolve #321

Also enables TestGasCostOnQuery, TestLimitRecursiveQueryGas

@alpe alpe changed the title Handle panics in query contract smart" Handle panics in query contract smart Nov 24, 2020
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #322 (1d3bc0e) into master (b0b407d) will decrease coverage by 0.35%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   69.46%   69.11%   -0.36%     
==========================================
  Files          28       28              
  Lines        2404     2341      -63     
==========================================
- Hits         1670     1618      -52     
+ Misses        616      606      -10     
+ Partials      118      117       -1     
Impacted Files Coverage Δ
x/wasm/internal/keeper/querier.go 55.68% <94.73%> (+4.69%) ⬆️
x/wasm/internal/keeper/keeper.go 90.56% <100.00%> (+0.61%) ⬆️
x/wasm/internal/types/proposal.go 89.81% <0.00%> (+0.45%) ⬆️

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

x/wasm/internal/keeper/querier.go Show resolved Hide resolved
x/wasm/internal/keeper/querier_test.go Show resolved Hide resolved
@alpe alpe merged commit eeb3797 into master Nov 30, 2020
@alpe alpe deleted the handle_oog_321 branch November 30, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of gas causes panic when external contract store query executed
2 participants