Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register upgrade plan for musselnet-v2 #351

Closed
wants to merge 2 commits into from

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented Dec 30, 2020

This change is required to succesfully executing a cosmovisor assisted upgrade. Reference: https://godoc.org/github.com/cosmos/cosmos-sdk/x/upgrade#hdr-Performing_Upgrades

@orkunkl orkunkl requested review from alpe and ethanfrey December 30, 2020 08:55
@alpe alpe changed the base branch from master to musselnet January 4, 2021 09:14
@alpe
Copy link
Contributor

alpe commented Jan 4, 2021

@orkunkl I have modified the target branch as discussed. Please update the "upgrade name". Otherwise looks good 👍

app/app.go Outdated
@@ -645,3 +645,9 @@ func initParamsKeeper(appCodec codec.BinaryMarshaler, legacyAmino *codec.LegacyA

return paramsKeeper
}

func (app *WasmApp) registerUpgradePlans() {
app.upgradeKeeper.SetUpgradeHandler("v0.13.1", func(ctx sdk.Context, plan upgradetypes.Plan) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would just name this "musselnet-v2" or something like that.

@ethanfrey
Copy link
Member

I heard some upgrade issues with -rc6 (maybe earlier). It would be good to do some local testing.

Once #354 is merged, please rebase on/merge from that one. And it would be good to locally test a (one node) upgrade from the current musselnet version (0.12.0?) to this commit.

I would be happy to report any issues to the cosmos sdk team. Or report that this worked without problems as a positive test.

@ethanfrey ethanfrey changed the title Register upgrade plan for v0.13.1 Register upgrade plan for musselnet-v2 Jan 7, 2021
@ethanfrey ethanfrey force-pushed the register-v0.13.1-upgrade-plan branch from 37833e2 to f691528 Compare January 7, 2021 14:03
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #351 (613e645) into musselnet (321491e) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##           musselnet     #351      +/-   ##
=============================================
- Coverage      57.19%   57.17%   -0.03%     
=============================================
  Files             33       33              
  Lines           3453     3456       +3     
=============================================
+ Hits            1975     1976       +1     
- Misses          1327     1328       +1     
- Partials         151      152       +1     
Impacted Files Coverage Δ
app/app.go 87.09% <33.33%> (-0.66%) ⬇️

@ethanfrey ethanfrey force-pushed the register-v0.13.1-upgrade-plan branch from 109bf3f to 613e645 Compare January 7, 2021 20:30
@ethanfrey
Copy link
Member

We will not perform this.
I will close the PR, but the branch is a good example of an upgrade script. Let's not delete the branch

@ethanfrey ethanfrey closed this Jan 19, 2021
@alpe alpe deleted the register-v0.13.1-upgrade-plan branch December 22, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants