-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register upgrade plan for musselnet-v2 #351
Conversation
@orkunkl I have modified the target branch as discussed. Please update the "upgrade name". Otherwise looks good 👍 |
app/app.go
Outdated
@@ -645,3 +645,9 @@ func initParamsKeeper(appCodec codec.BinaryMarshaler, legacyAmino *codec.LegacyA | |||
|
|||
return paramsKeeper | |||
} | |||
|
|||
func (app *WasmApp) registerUpgradePlans() { | |||
app.upgradeKeeper.SetUpgradeHandler("v0.13.1", func(ctx sdk.Context, plan upgradetypes.Plan) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would just name this "musselnet-v2" or something like that.
I heard some upgrade issues with -rc6 (maybe earlier). It would be good to do some local testing. Once #354 is merged, please rebase on/merge from that one. And it would be good to locally test a (one node) upgrade from the current musselnet version (0.12.0?) to this commit. I would be happy to report any issues to the cosmos sdk team. Or report that this worked without problems as a positive test. |
37833e2
to
f691528
Compare
Codecov Report
@@ Coverage Diff @@
## musselnet #351 +/- ##
=============================================
- Coverage 57.19% 57.17% -0.03%
=============================================
Files 33 33
Lines 3453 3456 +3
=============================================
+ Hits 1975 1976 +1
- Misses 1327 1328 +1
- Partials 151 152 +1
|
109bf3f
to
613e645
Compare
We will not perform this. |
This change is required to succesfully executing a cosmovisor assisted upgrade. Reference: https://godoc.org/github.com/cosmos/cosmos-sdk/x/upgrade#hdr-Performing_Upgrades