-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement relayer integration tests #395
Conversation
1bf56db
to
2c0b8b9
Compare
Hmmm... this assumes the relayer works? If it were stable, I think this would be a very good test. As relayer is still somewhat buggy and not at 1.0, I would wait. This branch is a good start, but let's make sure the other side is stable before we test our code against it. |
@ethanfrey Actually relayer works with recently launched two local networks. So tests will pass |
89d73be
to
bd9bacd
Compare
7d6e09b
to
06e6a7f
Compare
I appreciate the effort ❤️ but I have mixed feelings about adding the relayer into automated CI tests. How to move forward? The scripts are adding value to the project and make it easier to get started for anybody testing out IBC. Running them on CI is a bit controversy. I would suggest to move them to |
@alpe I agree these tests are bit shallow and insufficient. But at some point we will need IBC integration tests. We can leave the branch as it is, or exclude the tests from CI. |
Moved tests to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.:tulip:
A nice to have would be a README in the relayer-tests folder with thank you to the original authors and link to their repo.
This PR basically installs relayer on CI level, then executes the bash tests which located at
/integration
. These setup scripts are copied from relayer tests. For now the integration test setups up two wasm chains and sends token from one to another, then checks the balance. I made some changes on CI build. Not sure it will work as intended in the first try. Open for suggestions.