Start Pin/Unpin contract #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
reviewed
Mar 4, 2021
alpe
force-pushed
the
contract_pinning_401
branch
from
93a20e7
to
6c3c197
Compare
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 55.44% 55.69% +0.25%
==========================================
Files 39 39
Lines 4080 4189 +109
==========================================
+ Hits 2262 2333 +71
- Misses 1627 1663 +36
- Partials 191 193 +2
|
ethanfrey
approved these changes
Mar 9, 2021
| "testing" | ||
| ) | ||
|
|
||
| func BenchmarkExecution(b *testing.B) { |
There was a problem hiding this comment.
I'd love to see the numbers from this on, say, wasmd 0.12 (which had the old wasmer engine), so we can compare the speedup for uncached over the last 3-4 months, plus the huge speedup for pinned contracts
| if err := p.ValidateBasic(); err != nil { | ||
| return err | ||
| } | ||
| for _, v := range p.CodeIDs { |
There was a problem hiding this comment.
nice, i like the list of code ids
| } | ||
| require.NoError(t, gotErr) | ||
|
|
||
| // and proposal execute |
There was a problem hiding this comment.
nice shortcut to mock out the whole voting process
| @@ -388,12 +405,12 @@ func handleExecute(ctx sdk.Context, k *Keeper, msg *types.MsgExecuteContract) (* | |||
| return res, nil | |||
| } | |||
|
|
|||
| func RandomAccountAddress(_ *testing.T) sdk.AccAddress { | |||
| func RandomAccountAddress(_ TestingT) sdk.AccAddress { | |||
There was a problem hiding this comment.
There is a testing.TB interface I have seen before that probably is what you want here - one interface that lets you use the code both in unit tests as well as benchmarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #401