-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submsg and replies #441
Submsg and replies #441
Conversation
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 54.90% 55.56% +0.65%
==========================================
Files 39 39
Lines 4218 4305 +87
==========================================
+ Hits 2316 2392 +76
- Misses 1706 1712 +6
- Partials 196 201 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick feedback on the questions. No time for a proper review yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 🎸
Only the data payload may become an issue.
aba0596
to
00e99b8
Compare
Okay, I addressed all the comments and added a bug fix and test. Rebased on master (to include pinned contract metering) and please feel free to merge if it looks better now. |
Awesome feature, Thanks 💐 |
Closes #421
Note: we will need to update again after CosmWasm/cosmwasm#822 to add support for submessages in the ibc callbacks