Check coin sendable status #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 55.51% 55.63% +0.11%
==========================================
Files 39 39
Lines 4305 4312 +7
==========================================
+ Hits 2390 2399 +9
+ Misses 1713 1712 -1
+ Partials 202 201 -1
|
ethanfrey
approved these changes
Mar 10, 2021
|
|
||
| // TransferCoins transfers coins from source to destination account when coin send was enabled for them and the recipient | ||
| // is not in the blocked address list. | ||
| func (c CoinTransferrer) TransferCoins(ctx sdk.Context, fromAddr sdk.AccAddress, toAddr sdk.AccAddress, amt sdk.Coins) error { |
There was a problem hiding this comment.
This adds the logic well.
I was wondering about the abstraction here and why we don't just use the msg service. But maybe that requires a much larger refactor? Also the reasoning for your interfaces usually becomes clear to me a few weeks later, so I trust you on this one.
There was a problem hiding this comment.
Thanks but this might be over engineered. Keep challenging me. :-)
Main motivation was to not get into the type conversions for address and context (yet).
|
Very nice to see this resolved. 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
This also includes some minor refactoring towards interfaces in
Keeperand an extension point to customize the SendCoins precondition checks