Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non default transfer port id #462

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Handle non default transfer port id #462

merged 1 commit into from
Mar 18, 2021

Conversation

alpe
Copy link
Member

@alpe alpe commented Mar 18, 2021 •
edited
Loading

Resolves #396

@CosmWasm CosmWasm deleted a comment from codecov bot Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #462 (6996f72) into master (8e35dc2) will increase coverage by 0.05%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   56.63%   56.68%   +0.05%     
==========================================
  Files          40       40              
  Lines        4372     4373       +1     
==========================================
+ Hits         2476     2479       +3     
+ Misses       1685     1684       -1     
+ Partials      211      210       -1
Impacted Files Coverage Δ
x/wasm/internal/keeper/handler_plugin_encoders.go 78.28% <83.33%> (ø)
app/app.go 86.85% <100.00%> (+0.05%) ⬆️
x/wasm/internal/keeper/handler_plugin.go 85.13% <100.00%> (ø)
x/wasm/internal/keeper/keeper.go 86.35% <100.00%> (+0.40%) ⬆️

ethanfrey
ethanfrey approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

x/wasm/internal/keeper/keeper.go Show resolved Hide resolved
x/wasm/internal/keeper/wasmtesting/mock_keepers.go Show resolved Hide resolved
x/wasm/internal/keeper/handler_plugin_encoders.go Show resolved Hide resolved
@alpe alpe merged commit e3b5a6e into master Mar 18, 2021
@alpe alpe deleted the transfer_portid_396 branch March 18, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle non default IBC transfer port in message encoder
2 participants
@alpe @ethanfrey