Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to sdk v0.38 #47

Closed
wants to merge 5 commits into from
Closed

Conversation

sunnya97
Copy link
Contributor

Alternative close #15

If the goal is to merge gaia, then use #44

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@sunnya97 sunnya97 requested a review from ethanfrey as a code owner January 23, 2020 21:14
@codecov-io
Copy link

Codecov Report

Merging #47 into master will increase coverage by 1.74%.
The diff coverage is 71.31%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #47      +/-   ##
=========================================
+ Coverage   61.46%   63.2%   +1.74%     
=========================================
  Files          15      14       -1     
  Lines        1095    1098       +3     
=========================================
+ Hits          673     694      +21     
+ Misses        356     338      -18     
  Partials       66      66
Impacted Files Coverage Δ
app/export.go 7.31% <0%> (ø) ⬆️
x/wasm/internal/keeper/test_common.go 100% <100%> (ø) ⬆️
x/wasm/internal/keeper/keeper.go 67.46% <35%> (ø) ⬆️
x/wasm/internal/keeper/querier.go 26.13% <7.14%> (+2.42%) ⬆️
x/wasm/handler.go 85.91% <81.25%> (+1.62%) ⬆️
lcd_test/helpers.go 75.53% <91.66%> (ø) ⬆️
app/app.go 88.81% <93.1%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877c24d...c0dfcc9. Read the comment docs.

@ethanfrey
Copy link
Member

Thank you for the contribution, but I am rejecting this in favor of #44, as that merges in gaia/master and addresses all the requirements of issue #15

I feel bad closing this work, but let's try to check in on the issue better beforehand next time.

@ethanfrey ethanfrey closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to cosmos-sdk 0.38
3 participants