Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim code info #564

Merged
merged 6 commits into from
Jul 28, 2021
Merged

Trim code info #564

merged 6 commits into from
Jul 28, 2021

Conversation

ethanfrey
Copy link
Member

Closes #540

(More changes to protobuf as we bump to v1)

@ethanfrey ethanfrey requested a review from webmaster128 July 27, 2021 22:33
@ethanfrey ethanfrey requested a review from alpe as a code owner July 27, 2021 22:33
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #564 (18741cb) into master (6f684d5) will decrease coverage by 0.25%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
- Coverage   59.74%   59.49%   -0.26%     
==========================================
  Files          45       45              
  Lines        5277     5209      -68     
==========================================
- Hits         3153     3099      -54     
+ Misses       1893     1881      -12     
+ Partials      231      229       -2     
Impacted Files Coverage Δ
x/wasm/client/cli/genesis_msg.go 70.54% <ø> (-1.08%) ⬇️
x/wasm/client/cli/gov_tx.go 0.00% <ø> (ø)
x/wasm/client/cli/tx.go 25.00% <ø> (-0.98%) ⬇️
x/wasm/keeper/legacy_querier.go 69.23% <ø> (-0.67%) ⬇️
x/wasm/keeper/msg_server.go 0.00% <0.00%> (ø)
x/wasm/keeper/querier.go 60.55% <ø> (+0.22%) ⬆️
x/wasm/types/test_fixtures.go 94.97% <ø> (-0.15%) ⬇️
x/wasm/types/tx.go 38.35% <ø> (-1.65%) ⬇️
x/wasm/types/types.go 51.59% <0.00%> (-0.56%) ⬇️
x/wasm/types/validation.go 100.00% <ø> (+6.66%) ⬆️
... and 5 more

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make things simpler foor sure

proto/cosmwasm/wasm/v1/proposal.proto Outdated Show resolved Hide resolved
@ethanfrey ethanfrey force-pushed the 540-trim-code-info branch from f46967f to 18741cb Compare July 28, 2021 09:27
@ethanfrey ethanfrey merged commit 267643f into master Jul 28, 2021
@ethanfrey ethanfrey deleted the 540-trim-code-info branch July 28, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove (often unused) contract urls from CodeInfo
2 participants