Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cosmos-sdk v0.44 #678

Closed
wants to merge 7 commits into from
Closed

Upgrade to cosmos-sdk v0.44 #678

wants to merge 7 commits into from

Conversation

sunnya97
Copy link
Member

closes #501

@sunnya97 sunnya97 added the dependencies Pull requests that update a dependency file label Nov 21, 2021
@sunnya97
Copy link
Member Author

I just realized that there is already a PR for this in #656, and I think that's actually farther along in the process than I am. Should probably work off of that.

@ethanfrey
Copy link
Member

Hi Sunny, there are a lot of talks about this upgrade in the issue and on discord. Not sure if everything is written down.

In any case, there are at least 3 known forks that add 0.44 support. It is unclear all the design decisions/tradeoffs each one makes. But I think there is no need for another one. The best way to help move this forward is to reach out to @alpe and maybe offer a review of some code.

BTW, the biggest open question I think is with the 0.44 upgrade whether contracts should maintain 20 bytes "legacy" addresses like secp256k1, or use the new 32 byte "module account" address format.

@ethanfrey
Copy link
Member

We have communicated putting this into our 1.0 roadmap and will get started on it in a week or two.

@sunnya97
Copy link
Member Author

Got it! I'm gonna close this PR for now then. Btw, I would say I have a preference for the new 32 byte addresses, but I wonder if we do need to provide legacy support for old addresses?

@sunnya97 sunnya97 closed this Nov 23, 2021
@faddat
Copy link
Contributor

faddat commented Dec 7, 2021

9282758#commitcomment-61521105

Functionally speaking I am pretty good with the beta2-ibc2 branch at notional-labs/wasmd

but.....

It would be hell to merge in and out (think like osmosis fork of cosmos sdk)

So I am going to basically re-do your work here, using it as a template of sorts. I've also put together a whooooole bunch of tests and I hope to conclude with some kind of contract sanity test.

Cheers!

@alpe alpe deleted the sunny/update-v0.44 branch May 10, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Cosmos SDK v0.44
3 participants