Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no admin flag for gov #771

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Add no admin flag for gov #771

merged 1 commit into from
Mar 2, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 2, 2022

Resolves #768
The flag was missing

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #771 (70ee69a) into master (d4284fb) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage   58.47%   58.50%   +0.02%     
==========================================
  Files          49       49              
  Lines        5828     5829       +1     
==========================================
+ Hits         3408     3410       +2     
  Misses       2170     2170              
+ Partials      250      249       -1     
Impacted Files Coverage Δ
x/wasm/client/cli/gov_tx.go 0.00% <0.00%> (ø)
x/wasm/keeper/keeper.go 87.90% <0.00%> (+0.35%) ⬆️

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks to @gitabhishekgit for reporting this

@ethanfrey ethanfrey merged commit 64ac68e into master Mar 2, 2022
@ethanfrey ethanfrey deleted the 768-gov-noadmin branch March 2, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not Able to Instantiate the Contract using governance if admin is not provided
3 participants