Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make utils methods public #773

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Make utils methods public #773

merged 1 commit into from
Mar 3, 2022

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Mar 2, 2022

Make GetAllCodes and GetAllContracts methods public

Make GetAllCodes and GetAllContracts methods public
@pinosu pinosu force-pushed the make_utils_methods_public branch from d5fd758 to c33b1ad Compare March 2, 2022 19:28
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #773 (c33b1ad) into master (d4284fb) will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
+ Coverage   58.47%   58.51%   +0.03%     
==========================================
  Files          49       49              
  Lines        5828     5828              
==========================================
+ Hits         3408     3410       +2     
+ Misses       2170     2169       -1     
+ Partials      250      249       -1     
Impacted Files Coverage Δ
x/wasm/client/cli/genesis_msg.go 71.87% <83.33%> (ø)
x/wasm/keeper/keeper.go 87.90% <0.00%> (+0.35%) ⬆️

Copy link
Member

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just curious, why are there changes to go.mod/sum ?

@pinosu pinosu marked this pull request as ready for review March 2, 2022 22:17
@pinosu
Copy link
Contributor Author

pinosu commented Mar 2, 2022

My ide was saying that vendor folder is out of sync so I had to run go mod vendor and go mod tidy . So they got updated.

Copy link
Member

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pinosu pinosu merged commit bfa6a1c into master Mar 3, 2022
@alpe alpe deleted the make_utils_methods_public branch May 10, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants