Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpack contract details from genesis #802

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Unpack contract details from genesis #802

merged 2 commits into from
Apr 12, 2022

Conversation

alpe
Copy link
Member

@alpe alpe commented Apr 11, 2022

On state import the contract ContractInfoExtension was not unpacked proper. This PR adds some unpacker callbacks to solve this.

@alpe alpe added the bug Something isn't working label Apr 11, 2022
@alpe alpe requested a review from pinosu April 11, 2022 11:15
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #802 (5771e61) into master (64d39c3) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
+ Coverage   58.75%   58.76%   +0.01%     
==========================================
  Files          50       50              
  Lines        5855     5862       +7     
==========================================
+ Hits         3440     3445       +5     
- Misses       2163     2164       +1     
- Partials      252      253       +1     
Impacted Files Coverage Δ
x/wasm/types/genesis.go 93.44% <71.42%> (-2.86%) ⬇️
x/wasm/keeper/keeper.go 87.82% <100.00%> (ø)

@alpe alpe merged commit 68b4908 into master Apr 12, 2022
@alpe alpe deleted the unpack_details branch April 12, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants