Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gov param change examples #805

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Gov param change examples #805

merged 1 commit into from
Apr 14, 2022

Conversation

alpe
Copy link
Member

@alpe alpe commented Apr 13, 2022 •
edited
Loading

Relates to #804

  • Added json examples to x/wasm/Governance.md
  • Set proper encoding in tests

@alpe alpe requested a review from pinosu April 13, 2022 09:10
@alpe alpe changed the title Gov param changes Gov param change examples Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022 •
edited
Loading

Codecov Report

Merging #805 (45c826a) into master (ab661d5) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
+ Coverage   58.73%   58.76%   +0.03%     
==========================================
  Files          50       50              
  Lines        5862     5862              
==========================================
+ Hits         3443     3445       +2     
+ Misses       2165     2164       -1     
+ Partials      254      253       -1
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 87.82% <0.00%> (+0.34%) ⬆️

pinosu
pinosu reviewed Apr 13, 2022
View reviewed changes
x/wasm/Governance.md
"deposit": ""
}
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good examples!

pinosu
pinosu reviewed Apr 13, 2022
View reviewed changes
x/wasm/keeper/proposal_integration_test.go
Title: jsonProposal.Title,
Description: jsonProposal.Description,
Changes: jsonProposal.Changes.ToParamChanges(),
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pinosu
pinosu approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@alpe alpe merged commit 57ead1a into master Apr 14, 2022
@alpe alpe deleted the 804-param_change branch April 14, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu