Add query for the total supply of a coin #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2022
larry0x
changed the title
|
the CI tests fail because they depend on the PR for |
|
I love this. |
alpe
reviewed
Aug 24, 2022
| @@ -189,6 +189,16 @@ func BankQuerier(bankKeeper types.BankViewKeeper) func(ctx sdk.Context, request | |||
| } | |||
| return json.Marshal(res) | |||
| } | |||
| if request.Supply != nil { | |||
There was a problem hiding this comment.
This looks good. Some happy path test with the mock would be good for regression
|
This is now available with cosmwasm 1.1 and wasmvm 1.1. Once those are merged, we can rebase and merge this one. |
Closed
Magicloud
pushed a commit
to fpco/wasmd
that referenced
this pull request
Jan 13, 2023
* add bank supply query * remove a local dev dependency
conorpp
pushed a commit
to wormhole-foundation/wasmd
that referenced
this pull request
Feb 1, 2023
* add bank supply query * remove a local dev dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently it is not possible to query the total supply of a native SDK coin. this is something that protocols often need to do, especially that now contract are able to mint native coins thanks to the
tokenfactorymodule. this PR adds the binding for this query type.see also:
NOTE: the CI tests fail because they depend on the PR for
wasmvmbeing merged first