Don't pass non-wasm events to reply() #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output events are not part of consensus and can be non-deterministic
Codecov Report
@@ Coverage Diff @@
## main #917 +/- ##
==========================================
+ Coverage 59.15% 59.20% +0.04%
==========================================
Files 51 51
Lines 6199 6201 +2
==========================================
+ Hits 3667 3671 +4
+ Misses 2265 2264 -1
+ Partials 267 266 -1
|
Merged
mattverse
pushed a commit
to osmosis-labs/wasmd
that referenced
this pull request
Aug 12, 2022
…asm-events-to-reply Don't pass non-wasm events to reply()
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on the wonderful work of #915 (thank you assafmo)
Adds changelog entry and fixes tests so I can merge and release.