Add unpin code flag to store code proposal #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #979 +/- ##
==========================================
- Coverage 59.36% 59.32% -0.04%
==========================================
Files 51 51
Lines 6231 6238 +7
==========================================
+ Hits 3699 3701 +2
- Misses 2266 2271 +5
Partials 266 266
|
ethanfrey
reviewed
Sep 5, 2022
alpe
changed the title
alpe
suggested changes
Sep 6, 2022
alpe
reviewed
Sep 6, 2022
x/wasm/keeper/proposal_handler.go
Outdated
| @@ -68,7 +68,10 @@ func handleStoreCodeProposal(ctx sdk.Context, k types.ContractOpsKeeper, p types | |||
| if err != nil { | |||
| return err | |||
| } | |||
| return k.PinCode(ctx, codeID) | |||
| if p.PinCode { | |||
There was a problem hiding this comment.
This would become if !p.Unpinned (or similar name)
There was a problem hiding this comment.
switched to early return instead
// if code should not be pinned return earlier
if p.UnpinCode {
return nil
}
I think it has better readability, double negation logic confuses me a bit personally 😅 but I can change it if there is a preference.
|
If you can get this fixed up by Wednesday, happy to include this in the v0.29 release. |
jhernandezb
changed the title
ethanfrey
reviewed
Sep 6, 2022
jhernandezb
requested review from
alpe and
ethanfrey
and removed request for
alpe and
ethanfrey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #972 if you think it makes sense to have it as part of a governance proposal.