Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix omitempty spelling #275

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Fix omitempty spelling #275

merged 4 commits into from
Dec 13, 2021

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Dec 13, 2021

3 typos in the json code I found.

Also, fixed some broken issues that were merged before 😦

  • go mod tidy missing but enforced by CI.
  • gas prices off on the tests

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two more in https://github.com/CosmWasm/wasmvm/blob/main/types/queries.go. Could you fix those as well?

@ethanfrey
Copy link
Member Author

@webmaster128 passes tests now. happy if you can approve and merge

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay its incredibly annoying go mod tidy updates dependencies in go.mod. This way the CI job makes no sense.

The rest looks good

@webmaster128 webmaster128 merged commit 18e1252 into main Dec 13, 2021
@webmaster128 webmaster128 deleted the fix-json branch December 13, 2021 21:15
@webmaster128
Copy link
Member

Okay its incredibly annoying go mod tidy updates dependencies in go.mod.

It was failing on main too. Maybe a combination of different PRs merged. Let's see if it stabilizes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants