Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/improve-dev-infra-setup #229

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

isaacna
Copy link
Collaborator

@isaacna isaacna commented Mar 5, 2023

Description of Changes

Some of the steps in the dev-infrastructure README were out of order, so rearranging them based on my recent setup experience. Also added:

  • fixing an issue where dev-cookiecutter-metadata.yaml was not included as one of the copied files as part of get_cdp_infrastructure_stack, which would cause the setup to fail if there was a directory chosen besides the default cdp-backend/dev-infrastructure.
  • adding an optional cookiecutter_yaml param to the setup-and-deploy just command in case it's desired

@isaacna isaacna requested a review from evamaxfield March 5, 2023 23:23
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #229 (0cfbb85) into main (d1fb41e) will not change coverage.
The diff coverage is n/a.

❗ Current head 0cfbb85 differs from pull request most recent head 8b57a16. Consider uploading reports for the commit 8b57a16 to get more accurate results

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   72.16%   72.16%           
=======================================
  Files          50       50           
  Lines        3316     3316           
=======================================
  Hits         2393     2393           
  Misses        923      923           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@isaacna isaacna changed the title docs/improve-dev-infra-docs docs/improve-dev-infra-setup Mar 6, 2023
Copy link
Member

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments / changes. Thanks!!!

dev-infrastructure/README.md Outdated Show resolved Hide resolved
dev-infrastructure/README.md Outdated Show resolved Hide resolved
@isaacna isaacna merged commit 200d0e7 into CouncilDataProject:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants