Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--diagnosis-as-error when using --workspace #184

Closed
alex-courtis opened this issue Sep 28, 2024 · 1 comment · Fixed by #185
Closed

--diagnosis-as-error when using --workspace #184

alex-courtis opened this issue Sep 28, 2024 · 1 comment · Fixed by #185

Comments

@alex-courtis
Copy link
Contributor

CodeFormat check --diagnosis-as-error -w ... does not exit -1 when a warning/error is found.

CodeFormat check --diagnosis-as-error -f foo.lua does exit -1

This always returns true:

EmmyLuaCodeStyle/CodeFormat/src/LuaCheck.cpp

Line 113 in ebcd76a

bool LuaCheck::CheckWorkspace(const FormatContext &context) {

@alex-courtis
Copy link
Contributor Author

Use case: running check in CI

alex-courtis added a commit to alex-courtis/EmmyLuaCodeStyle that referenced this issue Sep 28, 2024
@alex-courtis
fix(CppCXY#184): --diagnosis-as-error when using --workspace
2128c55
This was referenced Sep 28, 2024
Merged
Merged
Closed
CppCXY added a commit that referenced this issue Sep 28, 2024
@CppCXY
Merge pull request #185 from alex-courtis/184-diagnosis-as-error-for-…
6bbe77f 
…workspace

fix(#184): --diagnosis-as-error when using --workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#184): --diagnosis-as-error when using --workspace alex-courtis/EmmyLuaCodeStyle
1 participant
@alex-courtis