Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call connect dosn't work #248

Closed
GhostNr1 opened this issue Apr 8, 2024 · 0 comments · Fixed by #274
Closed

Call connect dosn't work #248

GhostNr1 opened this issue Apr 8, 2024 · 0 comments · Fixed by #274
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.

Comments

@GhostNr1
Copy link

GhostNr1 commented Apr 8, 2024

Describe the bug

Calling connect dosn't listen to that signal and call the method on the connected callable.
If I use make callable I get error in the output
_call_internal: Script call error #2 with Node 9: Failed to parse expression: Callable(Score:, "_on_update_score") <C++ Source> /home/runner/work/godot-orchestrator/godot-orchestrator/src/script/instances/script_instance.cpp:799 @ _call_internal()

If I make a gd file with the callable instead the error is removed but the connection still don't call the callable method.
If I make a gd file that look like this
func connecting(fromNode: Object, fromSignal: String, toNode: Object, toFunction: String): fromNode.connect(fromSignal, Callable(toNode, toFunction))
image
I can connect to this node and everything is working.

So it looks like there are some error with call connect and maybe also Make Callable

Expected behavior

Dynamicly connect two scene with signals

Actual behavior

No response

How to Reproduce?

Connect it like this
image

Godot full version

4.2.1.stable

Orchestrator version

v2.0.stable.official [98f58dc]

Additional information

No response

@GhostNr1 GhostNr1 added the kind/bug A bug or regression in expected behavior. label Apr 8, 2024
@Naros Naros added bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Apr 8, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants