Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain mouse interactions cause Godot to crash in All Actions Menu #455

Closed
Naros opened this issue Jun 29, 2024 · 0 comments · Fixed by #456
Closed

Certain mouse interactions cause Godot to crash in All Actions Menu #455

Naros opened this issue Jun 29, 2024 · 0 comments · Fixed by #456
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone

Comments

@Naros
Copy link
Member

Naros commented Jun 29, 2024

Describe the bug

In the all actions menu perform the following steps:

  1. Search for Self
  2. Click on Variables to collapse & expand the tree
  3. Click anywhere in the area of the tree widget below Get self
  4. Editor crashes

The issue is that the dialog raises a nothing_selected signal in this case and the code is designed to operate on the selected item. However, Godot returns a TreeItem from Tree::get_selected despite the Variables item being non-selectable, and so this is what caused the segfault with the code path.

Possible fixes include:

  1. Remove the nothing_selected signal handler
  2. Guard the item_activated callback to check that the first column is selectable before dispatch

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

4.2, 4.3

Orchestrator version

2.1, 2.0

Additional information

No response

@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jun 29, 2024
@Naros Naros added this to the 2.1 milestone Jun 29, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jun 29, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant