Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing function argument types sets unexpected default values #487

Closed
Naros opened this issue Jul 6, 2024 · 0 comments · Fixed by #499
Closed

Changing function argument types sets unexpected default values #487

Naros opened this issue Jul 6, 2024 · 0 comments · Fixed by #499
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Jul 6, 2024

Describe the bug

When a user-defined script function is dragged onto the graph canvas and the function argument types are modified, the default value for the pin will sometimes be rendered with <null> for numeric/string data types.

Expected behavior

For user-defined functions, default values should always default to the initial specific Variant subtype value.

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

No response

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 6, 2024
@Naros Naros added this to the 2.1 milestone Jul 6, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 10, 2024
@Naros
CraterCrashGH-487 Changing function argument type resets default value
7097321
@Naros Naros mentioned this issue Jul 10, 2024
Merged
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 10, 2024
@Naros
CraterCrashGH-487 Changing function argument type resets default value
148d7b7
Naros added a commit that referenced this issue Jul 10, 2024
@Naros
GH-487 Changing function argument type resets default value
f7e000a
Naros added a commit that referenced this issue Jul 10, 2024
@Naros
GH-487 Changing function argument type resets default value
fdab5ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-487 Changing function argument type resets default value Naros/godot-orchestrator
1 participant
@Naros