Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of containsn which is not compatible with Godot 4.2.1 #521

Closed
Naros opened this issue Jul 14, 2024 · 0 comments · Fixed by #522
Closed

Fix usage of containsn which is not compatible with Godot 4.2.1 #521

Naros opened this issue Jul 14, 2024 · 0 comments · Fixed by #522
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Jul 14, 2024

Describe the bug

The 2.0 branch refuses to build due to GH-498 introducing containsn, which is not available in Godot 4.2.1.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

No response

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 14, 2024
@Naros Naros added this to the 2.1 milestone Jul 14, 2024
@Naros Naros changed the title Fix usage of containsn which is only compatible with Godot 4.3 Fix usage of containsn which is not compatible with Godot 4.2.1 Jul 14, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 14, 2024
@Naros
CraterCrashGH-521 Fix compatibility issue with Godot 4.2.1 and `conta…
36bf493 
…insn`
@Naros Naros mentioned this issue Jul 14, 2024
Merged
Naros added a commit that referenced this issue Jul 14, 2024
@Naros
GH-521 Fix compatibility issue with Godot 4.2.1 and containsn
3d99bc5
Naros added a commit that referenced this issue Jul 14, 2024
@Naros
GH-521 Fix compatibility issue with Godot 4.2.1 and containsn
d6b9352
Naros added a commit that referenced this issue Jul 14, 2024
@Naros
GH-521 Fix compatibility issue with Godot 4.2.1 and `set_auto_transla…
e18e7bd 
…te_mode`
Naros added a commit that referenced this issue Jul 14, 2024
@Naros
GH-521 Fix compatibility issue with Godot 4.2.1 and `set_auto_transla…
0ba992d 
…te_mode`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-521 Fix compatibility issue with Godot 4.2.1 and containsn Naros/godot-orchestrator
1 participant
@Naros