Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function return node expects a connection, even when setting a default return value #563

Closed
Naros opened this issue Jul 21, 2024 · 0 comments · Fixed by #564
Closed

Function return node expects a connection, even when setting a default return value #563

Naros opened this issue Jul 21, 2024 · 0 comments · Fixed by #564
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Jul 21, 2024

Describe the bug

When validating the Function return node, the validation still expects a connection if the return type is a Boolean or some other basic type where a default value can be supplied.

Expected behavior

Validation should not require a connection if a default value can be supplied.

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

No response

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 21, 2024
@Naros Naros added this to the 2.1 milestone Jul 21, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 21, 2024
@Naros
CraterCrashGH-563 Relax validation on function result node
544d0ab
@Naros Naros mentioned this issue Jul 21, 2024
Merged
Naros added a commit that referenced this issue Jul 21, 2024
@Naros
GH-563 Relax validation on function result node
53c628a
Naros added a commit that referenced this issue Jul 21, 2024
@Naros
GH-563 Relax validation on function result node
3dafdb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-563 Relax validation on function result node Naros/godot-orchestrator
1 participant
@Naros