Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knots can be created through nodes #584

Closed
Naros opened this issue Jul 24, 2024 · 0 comments · Fixed by #588
Closed

Knots can be created through nodes #584

Naros opened this issue Jul 24, 2024 · 0 comments · Fixed by #588
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Jul 24, 2024

Describe the bug

When a connection wire passes behind a node, the GraphEdit appears to allow the user to select the connection wire mistakenly and therefore be able to use the Ctrl+LMB keybind to create a knot.

Expected behavior

The GraphNode rect area should prevent any interaction with a connection wire.

Actual behavior

Pressed Ctrl+LMB atop of a GraphNode and a connection wire that is rendered behind the GraphNode allows a Knot to be placed or removed.

How to Reproduce?

No response

Godot full version

4.3.beta3

Orchestrator version

2.1.rc2

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 24, 2024
@Naros Naros added this to the 2.1 milestone Jul 24, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 26, 2024
@Naros
CraterCrashGH-584 Disable knot creation inside node rect
2d1ce8c
@Naros Naros mentioned this issue Jul 26, 2024
Merged
Naros added a commit that referenced this issue Jul 26, 2024
@Naros
GH-584 Disable knot creation inside node rect
679c0f6
Naros added a commit that referenced this issue Jul 26, 2024
@Naros
GH-584 Disable knot creation inside node rect
897182a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-584 Disable knot creation inside node rect Naros/godot-orchestrator
1 participant
@Naros