Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse to function looses pin type details & doesn't assign unique pin names #593

Closed
Naros opened this issue Jul 26, 2024 · 0 comments · Fixed by #600
Closed

Collapse to function looses pin type details & doesn't assign unique pin names #593

Naros opened this issue Jul 26, 2024 · 0 comments · Fixed by #600
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Jul 26, 2024

Describe the bug

GIven this graph:

image

When collapsing the gold-bordered nodes to a function, this yields an unexpected outcome in the function graph:

image

The function entry node does not properly assign the pin types, and instead just defaults to Object rather than Input. Additionally, and more importantly, the connection wires are mistakenly drawn due to this:

image

Both input pins are named target. By changing the pin names from target to target1 and target2, the connection wires are drawn correctly.

Finally, the Result Node seems randomly placed and not wired to anything.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

4.3.rc1

Orchestrator version

2.1.rc2

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 26, 2024
@Naros Naros added this to the 2.1 milestone Jul 26, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 27, 2024
@Naros
CraterCrashGH-593 Fix collapse to function bugs
73fe45b 
- Pins should retain type
- Multiple pins should not have the same name
- Optional return node
- Script function call nodes use argument namse
@Naros Naros mentioned this issue Jul 27, 2024
Merged
Naros added a commit that referenced this issue Jul 27, 2024
@Naros
GH-593 Fix collapse to function bugs
b7e2622 
- Pins should retain type
- Multiple pins should not have the same name
- Optional return node
- Script function call nodes use argument namse
Naros added a commit that referenced this issue Jul 27, 2024
@Naros
GH-593 Fix collapse to function bugs
ef26766 
- Pins should retain type
- Multiple pins should not have the same name
- Optional return node
- Script function call nodes use argument namse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-593 Fix collapse to function bugs Naros/godot-orchestrator
1 participant
@Naros