Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An orchestrator script causes game to crash #68

Closed
Naros opened this issue Jan 12, 2024 · 1 comment · Fixed by #69
Closed

An orchestrator script causes game to crash #68

Naros opened this issue Jan 12, 2024 · 1 comment · Fixed by #69
Labels
kind/bug A bug or regression in expected behavior.

Comments

@Naros
Copy link
Member

Naros commented Jan 12, 2024

Describe the bug

When creating a scene using an orchestration, certain combination of nodes cause the game to crash.combinations

Expected behavior

Game should not crash.

Actual behavior

Game crashes

How to Reproduce?

Create a simple scene with two child nodes:

+ Node3D
  + Node3DChild1
  + Node3DChild2

Create an orchestration attached to Node3DChild1 and add a _ready callback. Then drag Node3DChild2 onto the graph canvas to create an OScriptNodeSceneNode. Add a variable with type Object and then create an OScriptNodeVariableSet node and attach the scene node to the variable node.

The simple logic aims to set the variable with the scene node.

Now save the scene and run the scene, game crashes.

Godot full version

4.1.2-stable

Orchestrator version

2.0.dev1

Additional information

No response

@Naros Naros added the kind/bug A bug or regression in expected behavior. label Jan 12, 2024
@Naros
Copy link
Member Author

Naros commented Jan 12, 2024

Unfortunately, this bug was introduced by mistake due to a mistake in a property setting key; however, there is a workaround.

  1. Close the Godot project in the Godot Editor.
  2. Make a copy of your project.godot file in case you make a mistake here.
  3. Open the project.godot file with a text editor.
  4. Locate a section in the project file that starts with [orchestrator].

If the [orchestrator] section exists, then add the following to the [orchestrator] section:

settings/runtime/max_call_stack=256

If the [orchestrator] section does not exist in the project file, move to the end of the file and add these two lines instead:

[orchestrator]
settings/runtime/max_call_stack=256

Once the file is modified, save the file and restart the project in Godot. This should allow the game to run successfully.

This will be fixed in dev2.

Naros added a commit to Naros/godot-orchestrator that referenced this issue Jan 12, 2024
@Naros Naros closed this as completed in #69 Jan 12, 2024
Naros added a commit that referenced this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug or regression in expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant