Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orchestrations fail to load external resources #680

Closed
Naros opened this issue Aug 8, 2024 · 0 comments · Fixed by #681
Closed

Orchestrations fail to load external resources #680

Naros opened this issue Aug 8, 2024 · 0 comments · Fixed by #681
Labels
cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Aug 8, 2024

Describe the bug

When a variable refers to a default value such as a Resource like a Texture2D that refers to a file, the Orchestration will no longer be loadable and will fail with this error:

* src\script\serialization\text_loader_instance.cpp:348 - res://tests/await/await_test.torch:3 - ext_resource, invalid UID: uid://bebpqd2 - using text path instead: res://icon.svg
* src\script\serialization\text_loader_instance.cpp:515 - res://tests/await/await_test.torch:470 - Parse Error: Unknown identifier: 'ExternalResource'.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1.rc4

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Aug 8, 2024
@Naros Naros added this to the 2.1 milestone Aug 8, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 9, 2024
@Naros
CraterCrashGH-680 Fix loading external resources
52ffdf0
@Naros Naros mentioned this issue Aug 9, 2024
Merged
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 9, 2024
@Naros
CraterCrashGH-680 Fix loading external resources
8f0dae4
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 10, 2024
@Naros
CraterCrashGH-680 Support several serialization methods: `get_depende…
d7086e4 
…ncies`, `rename_dependencies`, and `get_resource_script_class`
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 10, 2024
@Naros
CraterCrashGH-680 Fix loading external resources
b768a06
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 10, 2024
@Naros
CraterCrashGH-680 Support several serialization methods: `get_depende…
e9d28b6 
…ncies`, `rename_dependencies`, and `get_resource_script_class`
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 11, 2024
@Naros
CraterCrashGH-680 Fix loading external resources
815c92b
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 11, 2024
@Naros
CraterCrashGH-680 Support several serialization methods: `get_depende…
d96a81e 
…ncies`, `rename_dependencies`, and `get_resource_script_class`
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 11, 2024
@Naros
CraterCrashGH-680 Support several serialization methods: `get_depende…
3f2f116 
…ncies`, `rename_dependencies`, and `get_resource_script_class`
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 11, 2024
@Naros
CraterCrashGH-680 Support several serialization methods: `get_depende…
49b4175 
…ncies`, `rename_dependencies`, and `get_resource_script_class`
Naros added a commit that referenced this issue Aug 11, 2024
@Naros
GH-680 Fix loading external resources
bb10544
Naros added a commit that referenced this issue Aug 11, 2024
@Naros
GH-680 Support several serialization methods: get_dependencies, `re…
57ec042 
…name_dependencies`, and `get_resource_script_class`
Naros added a commit that referenced this issue Aug 11, 2024
@Naros
GH-680 Fix loading external resources
bb235ee
Naros added a commit that referenced this issue Aug 11, 2024
@Naros
GH-680 Support several serialization methods: get_dependencies, `re…
83fe963 
…name_dependencies`, and `get_resource_script_class`
Naros added a commit that referenced this issue Aug 11, 2024
@Naros
GH-680 Fix crash on load
c280586
Naros added a commit that referenced this issue Aug 11, 2024
@Naros
GH-680 Fix crash on load
90bbe88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-680 Fix loading external resources Naros/godot-orchestrator
1 participant
@Naros