Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation for return node is too aggressive #774

Closed
Naros opened this issue Aug 23, 2024 · 0 comments · Fixed by #775
Closed

Validation for return node is too aggressive #774

Naros opened this issue Aug 23, 2024 · 0 comments · Fixed by #775
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Milestone
2.2

Comments

@Naros
Copy link
Member

Naros commented Aug 23, 2024

Describe the bug

For example, let's say we have a Sequence configuration as described in our step-by-step guide:

image

This causes validation errors

image

It is legal not to connect the output pins from the various sequence stages to the return node because these need to be executed sequentially.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.0.2.stable / 2.1.stable

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. labels Aug 23, 2024
@Naros Naros added this to the 2.2 milestone Aug 23, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 23, 2024
@Naros
CraterCrashGH-774 Relax return node validation for sequence nodes
f881921
@Naros Naros mentioned this issue Aug 23, 2024
Merged
@Naros Naros pinned this issue Aug 23, 2024
Naros added a commit that referenced this issue Aug 23, 2024
@Naros
GH-774 Relax return node validation for sequence nodes
3307fd1
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 23, 2024
@Naros
CraterCrashGH-774 Relax return node validation for sequence nodes
465ed9b
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 23, 2024
@Naros
CraterCrashGH-774 Relax return node validation for sequence nodes
5287539
Naros added a commit that referenced this issue Aug 25, 2024
@Naros
GH-774 Relax return node validation for sequence nodes
f6e8964
Naros added a commit that referenced this issue Aug 25, 2024
@Naros
GH-774 Relax return node validation for sequence nodes
7578002
@Naros Naros unpinned this issue Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

GH-774 Relax return node validation for sequence nodes Naros/godot-orchestrator
1 participant
@Naros