-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application crash on launch after adding Orchestrator (Godot 4.3, Orchestrator 2.1) #778
Comments
Do you have the latest 2015-2022 Microsoft C++ Redistributable installed @elmustardo ? |
Windows crash report log
|
@Naros I've tested each with a new project godot-orchestrator-v2.1-dev1-plugin - Works godot-orchestrator-v2.1-dev2-plugin - Works godot-orchestrator-v2.1-dev3-plugin - Works godot-orchestrator-v2.1-dev4-plugin - Works godot-orchestrator-v2.1-rc2-plugin - Works godot-orchestrator-v2.1-rc3-plugin - Works godot-orchestrator-v2.1-rc4-plugin - CRASH |
Excellent, thanks @elmustardo, time to dig into what changed between the two, I'll let you know what I find. |
Here are some commits between 2.1.rc3 and 2.1.rc4, can you verify if these demo projects do or do not run @elmustardo ? |
Here you go @Naros godot-orchestrator-demo-windows-release-24eb6e7 -- CRASH godot-orchestrator-demo-windows-release-46dc432 - Works |
Hi @elmustardo, can you check this one for me: godot-orchestrator-demo-windows-release-75ff266.zip I appreciate the help remotely bisecting where the commit failure is, not sure why it doesn't fail on Windows 11. |
@Naros For sure man. That one crashes for me as well. |
Ok lets try these @elmustardo, we're getting close |
godot-orchestrator-demo-windows-release-a0f141c - CRASH godot-orchestrator-demo-windows-release-d9354f9 - CRASH |
Ok, one last check @elmustardo, this will tell me which commit is the offender :) |
@Naros That one worked |
Awesome, so the offender is http://github.com/CraterCrash/godot-orchestrator/commit/9a5e5d53f38d57c93299227c4d7526583384f8ed, looking into the details of why. Can you confirm this file does or does not exist in your installation:
|
It does |
Ok @elmustardo does this demo work for you? If so, I'll prepare to cut a 2.1.1 tomorrow based on this change. |
Negative - This one is still crasthing. @Naros |
OK, thanks for confirming. In that case I'll revert the entire change in GH-653, thanks for confirming 👍 |
Right on man. Happy to help! |
Do you have any |
@Naros there are not. I test with a brand new project each time, dropping in the addon folder. |
Describe the bug
Application crash on launch after adding Orchestrator (Godot 4.3, Orchestrator 2.1)
This occurs immediately after installing the addon and going through the save & restart process)
Note this is on a brand new, blank project.
Expected behavior
I'd expect the application to launch lol
Actual behavior
Godot splash opens, then quickly closes.
Following logs are from windows event viewer
How to Reproduce?
No response
Godot full version
4.3.Stable.Official
Orchestrator version
godot-orchestrator-v2.1-stable-plugin
Additional information
N/A
The text was updated successfully, but these errors were encountered: