Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godot's get_current_scene can return a nullptr, causing a crash #796

Closed
Naros opened this issue Sep 7, 2024 · 0 comments · Fixed by #797
Closed

Godot's get_current_scene can return a nullptr, causing a crash #796

Naros opened this issue Sep 7, 2024 · 0 comments · Fixed by #797
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Milestone
2.2

Comments

@Naros
Copy link
Member

Naros commented Sep 7, 2024

Describe the bug

The PropertyGet, PropertySet, ShowMessage, and PrintString nodes all use the get_tree()->get_current_scene() API. While we have not seen any issues with its usage in our demos, some users have reported crashes.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1.1.stable / 2.0.3.stable

Additional information

The workaround appears to use get_tree()->get_root() instead.
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. labels Sep 7, 2024
@Naros Naros added this to the 2.2 milestone Sep 7, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-796 Guard against get_current_scene returning null
d2ca7a1
@Naros Naros mentioned this issue Sep 7, 2024
Merged
Naros added a commit that referenced this issue Sep 7, 2024
@Naros
GH-796 Guard against get_current_scene returning null
dc0b0f9
@Naros Naros closed this as completed in #797 Sep 7, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-796 Guard against get_current_scene returning null
5c063bc
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-796 Guard against get_current_scene returning null
3f3c30e
Naros added a commit that referenced this issue Oct 5, 2024
@Naros
GH-796 Guard against get_current_scene returning null
d8a8322
Naros added a commit that referenced this issue Oct 5, 2024
@Naros
GH-796 Guard against get_current_scene returning null
64a9452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

GH-796 Guard against get_current_scene returning null Naros/godot-orchestrator
1 participant
@Naros