Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate scene should not cache loaded scene. #798

Closed
Naros opened this issue Sep 7, 2024 · 0 comments · Fixed by #799
Closed

Instantiate scene should not cache loaded scene. #798

Naros opened this issue Sep 7, 2024 · 0 comments · Fixed by #799
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Milestone
2.2

Comments

@Naros
Copy link
Member

Naros commented Sep 7, 2024

Describe the bug

The Instantiate Scene node attempts to be smart by caching the loaded scene resource; however that's unnecessary since the resource subsystem does this automatically. This leads to an issue where calling the node with different arguments will lead to the same scene being created despite the input arguments being different.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1.1.stable / 2.0.3.stable

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. labels Sep 7, 2024
@Naros Naros added this to the 2.2 milestone Sep 7, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-798 Remove unnecessary instantiate scene cache
9dd1a77
@Naros Naros mentioned this issue Sep 7, 2024
Merged
Naros added a commit that referenced this issue Sep 7, 2024
@Naros
GH-798 Remove unnecessary instantiate scene cache
5da872b
@Naros Naros closed this as completed in #799 Sep 7, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-798 Remove unnecessary instantiate scene cache
74bb446
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-798 Remove unnecessary instantiate scene cache
bb5c256
Naros added a commit that referenced this issue Oct 5, 2024
@Naros
GH-798 Remove unnecessary instantiate scene cache
946f314
Naros added a commit that referenced this issue Oct 5, 2024
@Naros
GH-798 Remove unnecessary instantiate scene cache
b768952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

GH-798 Remove unnecessary instantiate scene cache Naros/godot-orchestrator
1 participant
@Naros