Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript await does not work on Orchestrator exposed signals #807

Closed
Naros opened this issue Sep 14, 2024 · 0 comments · Fixed by #808
Closed

GDScript await does not work on Orchestrator exposed signals #807

Naros opened this issue Sep 14, 2024 · 0 comments · Fixed by #808
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Milestone
2.2

Comments

@Naros
Copy link
Member

Naros commented Sep 14, 2024

Describe the bug

When a signal is defined in an Orchestration, a GDScript that uses await <signal> fails to locate the signal.

Expected behavior

The GDScript should await as if it were a GDScript signal.

Actual behavior

GDScript fails with a breakpoint that the signal cannot be found.

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1.1.stable / 2.0.3.stable

Additional information

The issue is that await uses named-based lookups via the Script API get method call, which currently does not lookup signals. The runtime instance should be adjusted to support such lookups.
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. labels Sep 14, 2024
@Naros Naros added this to the 2.2 milestone Sep 14, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 14, 2024
@Naros
CraterCrashGH-807 Support named lookup of signals, used by await ke…
2fc01a4 
…yword
@Naros Naros mentioned this issue Sep 14, 2024
Merged
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 14, 2024
@Naros
CraterCrashGH-807 Support named lookup of signals, used by await ke…
318343d 
…yword
Naros added a commit that referenced this issue Sep 14, 2024
@Naros
GH-807 Support named lookup of signals, used by await keyword
4e2824a
Naros added a commit that referenced this issue Sep 14, 2024
@Naros
GH-807 Support named lookup of signals, used by await keyword
22be5b3
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 14, 2024
@Naros
CraterCrashGH-807 Support named lookup of signals, used by await ke…
cb90bc4 
…yword
Naros added a commit that referenced this issue Oct 5, 2024
@Naros
GH-807 Support named lookup of signals, used by await keyword
7d30c6a
Naros added a commit that referenced this issue Oct 5, 2024
@Naros
GH-807 Support named lookup of signals, used by await keyword
95d418e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

GH-807 Support named lookup of signals, used by await keyword Naros/godot-orchestrator
1 participant
@Naros