Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-283 Support method chaining #294

Merged
merged 1 commit into from
Apr 25, 2024
Merged

GH-283 Support method chaining #294

merged 1 commit into from
Apr 25, 2024

Conversation

Naros
Copy link
Member

@Naros Naros commented Apr 24, 2024

Fixes #283

@Naros Naros added this to the 2.1 milestone Apr 24, 2024
@Naros Naros added the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Apr 25, 2024
@Naros
Copy link
Member Author

Naros commented Apr 25, 2024 •
edited
Loading

Few bugs identified:

  • Unchecking the Chain option does not disconnect the connection, leading to GraphEdit/GraphNode errors.
  • Duplicating a chained node using Ctrl+D works, Copy-n-Paste does not copy the Chain state.

@Naros Naros merged commit 43f7f48 into CraterCrash:main Apr 25, 2024
8 checks passed
@Naros
Copy link
Member Author

Naros commented Apr 25, 2024

Applied to main (=2.1) and branch 2.0.

@Naros Naros removed the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Call function nodes should have optional target output pin
1 participant
@Naros