Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-383 Split out Orchestration contract and refactors #386

Merged
merged 1 commit into from
Jun 8, 2024
Merged

GH-383 Split out Orchestration contract and refactors #386

merged 1 commit into from
Jun 8, 2024

Conversation

Naros
Copy link
Member

@Naros Naros commented Jun 7, 2024

Fixes #383

@Naros Naros added this to the 2.1 milestone Jun 7, 2024
@Naros Naros added the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jun 7, 2024
Naros
Naros commented Jun 7, 2024
View reviewed changes
Copy link
Member Author

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inline things to change.

src/editor/component_panels/signals_panel.cpp Show resolved Hide resolved
src/editor/graph/actions/default_action_registrar.cpp Outdated Show resolved Hide resolved
src/editor/graph/graph_edit.cpp Outdated Show resolved Hide resolved
src/editor/graph/graph_edit.cpp Outdated Show resolved Hide resolved
src/editor/graph/graph_edit.cpp Outdated Show resolved Hide resolved
src/orchestration/orchestration.cpp Outdated Show resolved Hide resolved
src/orchestration/orchestration.cpp Show resolved Hide resolved
src/orchestration/orchestration.cpp Show resolved Hide resolved
src/script/graph.cpp Outdated Show resolved Hide resolved
src/script/graph.cpp Outdated Show resolved Hide resolved
@Naros Naros merged commit a12f6b6 into CraterCrash:main Jun 8, 2024
8 checks passed
@Naros Naros deleted the GH-383 branch June 8, 2024 01:39
@Naros
Copy link
Member Author

Naros commented Jun 8, 2024

Applied to main (=2.1) and branch 2.0.

@Naros Naros removed the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Split the notion of an Orchestration
1 participant
@Naros