Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-537 Fix resolution of script on object types #538

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

Naros
Copy link
Member

@Naros Naros commented Jul 16, 2024

Fixes #537

@Naros Naros added the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jul 16, 2024
@Naros Naros added this to the 2.1 milestone Jul 16, 2024
* Resolves methods, properties, and signals on nodes & scripts
* Correctly assigns target types for global class types
* Excludes private properties, prefixed with `_`
* Excludes internal methods, prefixed with `@`
* Reworks method/properties/signals for global classes
@Naros Naros merged commit c011903 into CraterCrash:main Jul 20, 2024
8 checks passed
@Naros Naros deleted the GH-537 branch July 20, 2024 00:14
@Naros
Copy link
Member Author

Naros commented Jul 20, 2024

Applied to main (=2.1) and branch 2.0, including commit #674fb74.

@Naros Naros removed the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolving object types can fail and fallback to base type only.
1 participant