Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-607 Improve changing variable types #608

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

Naros
Copy link
Member

@Naros Naros commented Jul 28, 2024

Fixes #607

Change Highlights

  • Add confirmation dialog with warning
  • Attempt to coerce most common types between one another
  • Retain VariableSet manual default values if they can be converted
  • Break any connections with Variable Get/Set if types are incompatible

- Add confirmation dialog with warning
- Attempt to coerce most common types between one another
- Retain VariableSet values if they can be converted
- Break any connections with Variable Get/Set if types are incompatible
@Naros Naros added the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jul 28, 2024
@Naros Naros added this to the 2.1 milestone Jul 28, 2024
@Naros Naros merged commit bfd94ff into CraterCrash:main Jul 29, 2024
8 checks passed
@Naros Naros deleted the GH-607 branch July 29, 2024 02:30
@Naros
Copy link
Member Author

Naros commented Jul 29, 2024

Applied to main (=2.1) and branch 2.0.

@Naros Naros removed the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing variable type resets default values
1 participant