Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-761 Use new ClassDB methods to fetch property getter/setter #802

Merged
merged 1 commit into from
Sep 8, 2024
Merged

GH-761 Use new ClassDB methods to fetch property getter/setter #802

merged 1 commit into from
Sep 8, 2024

Conversation

Naros
Copy link
Member

@Naros Naros commented Sep 8, 2024

Fixes #761

Without the fix
image

With the fix
image

@Naros Naros added the requires/godot-4.4 Requires Godot 4.4 label Sep 8, 2024
@Naros Naros added this to the 2.2 milestone Sep 8, 2024
@Naros Naros merged commit 32a2b02 into CraterCrash:main Sep 8, 2024
8 checks passed
@Naros Naros deleted the GH-761 branch September 8, 2024 09:12
@Naros
Copy link
Member Author

Naros commented Sep 8, 2024

As this is guarded by GODOT_VERSION, this logic will be enabled when we bump to Godot 4.4 as baseline.

@Naros Naros linked an issue Sep 8, 2024 that may be closed by this pull request
Method/Property precedence logic inconsistent when class accessor/mutator methods use unexpected conventions #601
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
requires/godot-4.4 Requires Godot 4.4
Projects
None yet
Milestone
2.2
1 participant
@Naros