Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/skern 4961 least privilege access model nmd api and cps api (… #37

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Feature/skern 4961 least privilege access model nmd api and cps api (… #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kubernetes/cray-opa/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#
apiVersion: v2
name: cray-opa
version: 1.10.0
version: 1.10.1
description: Cray Open Policy Agent
keywords:
- opa
Expand Down
56 changes: 14 additions & 42 deletions kubernetes/cray-opa/templates/_policy-ingressgateway.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- /*
Copyright 2021 Hewlett Packard Enterprise Development LP
Copyright 2021,2022 Hewlett Packard Enterprise Development LP
*/ -}}
{{ define "ingressgateway.policy" }}

Expand Down Expand Up @@ -244,14 +244,12 @@ allowed_methods := {
{"method": "PATCH", "path": `^/apis/cfs/components/.*$`},
{"method": "PATCH", "path": `^/apis/cfs/v./components/.*$`},

{"method": "GET", "path": `^/apis/v2/cps/.*$`},
{"method": "HEAD", "path": `^/apis/v2/cps/.*$`},
{"method": "POST", "path": `^/apis/v2/cps/.*$`},
{"method": "GET", "path": `^/apis/v2/cps/transports`},
{"method": "POST", "path": `^/apis/v2/cps/contents$`},
{"method": "POST", "path": `^/apis/v2/cps/transports$`},

{"method": "PUT", "path": `^/apis/v2/nmd/status/.*$`},

{"method": "GET", "path": `^/apis/v2/nmd/.*$`},
{"method": "HEAD", "path": `^/apis/v2/nmd/.*$`},
{"method": "POST", "path": `^/apis/v2/nmd/.*$`},
{"method": "PUT", "path": `^/apis/v2/nmd/.*$`},
#SMD -> GET everything, DVS currently needs to update BulkSoftwareStatus
{"method": "GET", "path": `^/apis/smd/hsm/v./.*$`},
{"method": "HEAD", "path": `^/apis/smd/hsm/v./.*$`},
Expand Down Expand Up @@ -320,10 +318,7 @@ allowed_methods := {
{"method": "HEAD", "path": `.*`},
],
"ckdump": [
{"method": "GET", "path": `^/apis/v2/nmd/.*$`},
{"method": "HEAD", "path": `^/apis/v2/nmd/.*$`},
{"method": "POST", "path": `^/apis/v2/nmd/.*$`},
{"method": "PUT", "path": `^/apis/v2/nmd/.*$`},
{"method": "PUT", "path": `^/apis/v2/nmd/status/.*$`},
],
}

Expand Down Expand Up @@ -356,38 +351,23 @@ spire_methods := {
{{- end }}
],
"cps": [
{"method": "GET", "path": `^/apis/v2/cps/.*$`},
{"method": "HEAD", "path": `^/apis/v2/cps/.*$`},
{"method": "POST", "path": `^/apis/v2/cps/.*$`},
{"method": "GET", "path": `^/apis/v2/cps/transports`},
{"method": "POST", "path": `^/apis/v2/cps/contents$`},
{"method": "POST", "path": `^/apis/v2/cps/transports$`},
],
"dvs": [

{{- if .Values.opa.xnamePolicy.dvs }}
{"method": "GET", "path": sprintf("^/apis/v2/nmd/status/%v$", [parsed_spire_token.xname])},
{"method": "PUT", "path": sprintf("^/apis/v2/nmd/status/%v$", [parsed_spire_token.xname])},
{"method": "GET", "path": `^/apis/v2/nmd/sdf/dump/discovery$`},
{"method": "GET", "path": `^/apis/v2/nmd/sdf/dump/targets`},
{"method": "GET", "path": `^/apis/v2/nmd/status$`},
{"method": "GET", "path": `^/apis/v2/nmd/healthz/live$`},
{"method": "GET", "path": `^/apis/v2/nmd/healthz/ready$`},

{"method": "GET", "path": sprintf("^/apis/hmnfd/hmi/v2/subscriptions/%v/agents$", [parsed_spire_token.xname])},
{"method": "POST", "path": sprintf("^/apis/hmnfd/hmi/v2/subscriptions/%v/agents/", [parsed_spire_token.xname])},
{"method": "PATCH", "path": sprintf("^/apis/hmnfd/hmi/v2/subscriptions/%v/agents/", [parsed_spire_token.xname])},
{"method": "DELETE", "path": sprintf("^/apis/hmnfd/hmi/v2/subscriptions/%v/agents/", [parsed_spire_token.xname])},
{{- else }}
{"method": "POST", "path": `^/apis/v2/nmd/dumps$`},
{"method": "PUT", "path": `^/apis/v2/nmd/.*$`},
{"method": "GET", "path": `^/apis/v2/nmd/.*$`},
{"method": "POST", "path": `^/apis/hmnfd/hmi/v1/subscribe$`},

{"method": "GET", "path": `^/apis/hmnfd/hmi/v2/subscriptions/.*$`},
{"method": "POST", "path": `^/apis/hmnfd/hmi/v2/subscriptions/.*$`},
{"method": "PATCH", "path": `^/apis/hmnfd/hmi/v2/subscriptions/.*$`},
{"method": "DELETE", "path": `^/apis/hmnfd/hmi/v2/subscriptions/.*$`},
{{- end }}
{"method": "HEAD", "path": `^/apis/v2/nmd/.*$`},
{"method": "POST", "path": `^/apis/v2/nmd/artifacts$`},
# These pass xnames via POST. This will be removed once the v2 API is being used.
{"method": "POST", "path": `^/apis/hmnfd/hmi/v1/subscribe$`},

Expand All @@ -404,17 +384,11 @@ spire_methods := {
{"method": "DELETE","path": `^/apis/hmnfd/hmi/v1/subscribe$`},
],
"ckdump": [
{{- if .Values.opa.xnamePolicy.dvs }}
{"method": "GET", "path": sprintf("^/apis/v2/nmd/dumps\\?xname=%v$", [parsed_spire_token.xname])},
{"method": "GET", "path": `^/apis/v2/nmd/dumps/.*$`},
{"method": "GET", "path": `^/apis/v2/nmd/sdf/dump/.*$`},
{{- if .Values.opa.xnamePolicy.ckdump }}
{"method": "PUT", "path": sprintf("^/apis/v2/nmd/status/%v$", [parsed_spire_token.xname])},
{{- else }}
{"method": "GET", "path": `^/apis/v2/nmd/.*$`},
{"method": "PUT", "path": `^/apis/v2/nmd/status/.*$`},
{{- end }}
{"method": "HEAD", "path": `^/apis/v2/nmd/.*$`},
# This method passes xname via POST
{"method": "POST", "path": `^/apis/v2/nmd/dumps$`},
],
"wlm": [
# PALS - application launch
Expand Down Expand Up @@ -480,8 +454,6 @@ sub_match = {
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/compute/XNAME/workload/wlm": spire_methods["wlm"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/XNAME/workload/bos-state-reporter": spire_methods["bos"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/XNAME/workload/cfs-state-reporter": spire_methods["cfs"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/XNAME/workload/ckdump": spire_methods["ckdump"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/XNAME/workload/ckdump_helper": spire_methods["ckdump"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/XNAME/workload/cpsmount": spire_methods["cps"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/XNAME/workload/cpsmount_helper": spire_methods["cps"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/XNAME/workload/dvs-hmi": spire_methods["dvs"],
Expand Down Expand Up @@ -513,9 +485,9 @@ sub_match = {
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/storage/workload/cfs-state-reporter": allowed_methods["system-compute"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/workload/cfs-state-reporter": allowed_methods["system-compute"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/compute/workload/ckdump": allowed_methods["ckdump"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/workload/ckdump": allowed_methods["ckdump"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/uan/workload/ckdump": allowed_methods["ckdump"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/compute/workload/ckdump_helper": allowed_methods["ckdump"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/workload/ckdump_helper": allowed_methods["ckdump"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/uan/workload/ckdump_helper": allowed_methods["ckdump"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/compute/workload/cpsmount": allowed_methods["system-compute"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/ncn/workload/cpsmount": allowed_methods["system-compute"],
"spiffe://{{ .Values.jwtValidation.spire.trustDomain }}/compute/workload/cpsmount_helper": allowed_methods["system-compute"],
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/cray-opa/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
env:
- name: POLICY_CONFIGMAP_VERSION
# Change to force opa pods to restart and re-read ConfigMap.
value: "7"
value: "8"
{{- if $.Values.opa.httpTimeout }}
- name: HTTP_SEND_TIMEOUT
value: {{ $.Values.opa.httpTimeout | quote }}
Expand Down
18 changes: 9 additions & 9 deletions kubernetes/cray-opa/tests/opa/ingressgateway_policy_test.rego.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2021 Hewlett Packard Enterprise Development LP
# Copyright 2021,2022 Hewlett Packard Enterprise Development LP

package istio.authz
## HOW TO DO UNIT TESTING
Expand Down Expand Up @@ -91,15 +91,15 @@ test_compute {

# NMD - Allowed

not allow.http_status with input as {"attributes": {"request": {"http": {"method": "GET", "path": nmd_mock_path, "headers": {"authorization": compute_auth}}}}}
not allow.http_status with input as {"attributes": {"request": {"http": {"method": "PUT", "path": "/apis/v2/nmd/status/x1", "headers": {"authorization": compute_auth}}}}}

not allow.http_status with input as {"attributes": {"request": {"http": {"method": "HEAD", "path": nmd_mock_path, "headers": {"authorization": compute_auth}}}}}
# NMD - Not Allowed

not allow.http_status with input as {"attributes": {"request": {"http": {"method": "POST", "path": nmd_mock_path, "headers": {"authorization": compute_auth}}}}}
allow.http_status == 403 with input as {"attributes": {"request": {"http": {"method": "GET", "path": nmd_mock_path, "headers": {"authorization": compute_auth}}}}}

not allow.http_status with input as {"attributes": {"request": {"http": {"method": "PUT", "path": nmd_mock_path, "headers": {"authorization": compute_auth}}}}}
allow.http_status == 403 with input as {"attributes": {"request": {"http": {"method": "HEAD", "path": nmd_mock_path, "headers": {"authorization": compute_auth}}}}}

# NMD - Not Allowed
allow.http_status == 403 with input as {"attributes": {"request": {"http": {"method": "POST", "path": nmd_mock_path, "headers": {"authorization": compute_auth}}}}}

allow.http_status == 403 with input as {"attributes": {"request": {"http": {"method": "PATCH", "path": nmd_mock_path, "headers": {"authorization": compute_auth}}}}}

Expand Down Expand Up @@ -235,9 +235,9 @@ test_spire_subs {

spire_ckdump(spire_sub) {

not allow.http_status with input as {"attributes": {"request": {"http": {"method": "GET", "path": nmd_mock_path, "headers": {"authorization": spire_sub}}}}}
not allow.http_status with input as {"attributes": {"request": {"http": {"method": "HEAD", "path": nmd_mock_path, "headers": {"authorization": spire_sub}}}}}
not allow.http_status with input as {"attributes": {"request": {"http": {"method": "POST", "path": nmd_mock_path, "headers": {"authorization": spire_sub}}}}}
allow.http_status == 403 with input as {"attributes": {"request": {"http": {"method": "GET", "path": nmd_mock_path, "headers": {"authorization": spire_sub}}}}}
allow.http_status == 403 with input as {"attributes": {"request": {"http": {"method": "HEAD", "path": nmd_mock_path, "headers": {"authorization": spire_sub}}}}}
allow.http_status == 403 with input as {"attributes": {"request": {"http": {"method": "POST", "path": nmd_mock_path, "headers": {"authorization": spire_sub}}}}}

allow.http_status == 403 with input as {"attributes": {"request": {"http": {"method": "GET", "path": cfs_mock_path, "headers": {"authorization": spire_sub}}}}}
allow.http_status == 403 with input as {"attributes": {"request": {"http": {"method": "HEAD", "path": cfs_mock_path, "headers": {"authorization": spire_sub}}}}}
Expand Down
Loading