Regression fix: Added pause check in MovieClip.__tick #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggVGc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently while updating from 0.7.0 to 0.8.1, we noticed some occasional odd behaviour with MovieClips.
The issue is showcased in this fiddle, http://jsfiddle.net/z4mfq25j/1/
Essentially movieclips that are supposed to be stopped, sometimes play through once before looping and then stopping. It seems a check for
this.pausedhas gone missing from the __tick method of MovieClip, compared to the 0.7.0 version, seemingly from refactoring and the addition of theadvancemethod which did not previously exist.This PR adds it again, and solves the issue for us, but is not extensively tested.