Preserving BakedModel and switching to ItemRenderer.render instead of ItemRenderer.renderStatic #6674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ItemRenderer.renderStatic for performance
IThundxr
added
pr type: feature
Merged
|
Thank you very much 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of renderItems calls get the BakedModel to check for isGui3d() then call renderStatic multiple times for the stack. ItemRenderer.renderStatic fetch the BakedModel and call ItemRenderer.render. Saving the BakedModel when used, allows us to call ItemRenderer.render() directly without fetching the baked model up to 4 times and saves CPU usage.
On a big factory with a lot of items, this allowed me to go from ~25fps to ~35fps