This repository has been archived by the owner on Aug 16, 2018. It is now read-only.
move database to class extension #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! This looks like a nice, low risk refactor. Merging now 👍 |
| aggregateByDate(pipeline={}, options, date) { | ||
| return this.aggregateRaw({ ...pipeline, $match: addDate(pipeline.$match, date) }, options); | ||
| aggregate(...pipeline) { | ||
| return this._aggregateWrapper(addCurrent, null, pipeline); |
There was a problem hiding this comment.
I'm a little confused by the spread operators. Shouldn't the first argument to aggregate be an array already?
While it's true that promised-mongo passes an object in the example you linked (and in their aggregate test, I think this is actually a bug and should be passing an array (which is the Mongo API):
gordonmleigh/promised-mongo#27
Our app code uses that array format too.
|
updated to require array pipeline |
yangchristian
added a commit
that referenced
this pull request
Oct 17, 2015
move database to class extension
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
TemporalDatabaseas a decendent ofpromised-mongo'sDatabase.(also adds aggregate api fix to emulate promised-mongo's approach: https://github.com/gordonmleigh/promised-mongo/blob/master/lib/Collection.js#L40-L43