Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for docutils 0.19 #49

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Update for docutils 0.19 #49

merged 1 commit into from
Jul 27, 2022

Conversation

codeThatThinks
Copy link

ErrorString and SafeString are deprecated and have been removed in docutils 0.19. This PR replaces ErrorString with io.error_string and SafeString with Python's builtin str().

See docutils:HISTORY.txt and docutils:utils/error_reporting.py for more information.

@CrossNox
Copy link
Owner

Thanks for the PR! Seems straighforward, but I will look into it later tonight.
My concern is that python2.7 seems to be incompatible with the latest docutils versions, so I'll run the full tests suite and check.

@CrossNox CrossNox merged commit 9096867 into CrossNox:development Jul 27, 2022
@CrossNox
Copy link
Owner

Ok, so my plan is as follows:

  • Merge this PR and release a new version, so as to avoid broken pipelines (forcing docutils <= 0.18 seemed weird in this regard)
  • Drop python2 support altogether in a future release. I'll be thinking what the best way to go about that would be.

@adrien-berchet
Copy link

Hi @CrossNox
Would it be possible to release a new version as you planned please? As you said, it's a bit annoying to force docutils <= 0.18 in every repos.
Thanks

@CrossNox
Copy link
Owner

Yep, sorry, had my last final last night. Will work on this later today. Tests were not passing and was not quite as straightforward as I had planned.

@adrien-berchet
Copy link

Ok, I see, no problem. Thank you very much to work on this :)

CrossNox added a commit that referenced this pull request Aug 11, 2022
* force mistune to version 0.8.4 (#43)

closes #42 
closes #40

* pin

* Remove calls to ErrorString and SafeString removed in docutils 0.19 (#49)

* remove python2

* fix pipelines

* fix linter pipeline

* set language for sphinx

* fix tests pipeline

* fix pipeline, set docutiles dependency

* why did I change this

* bump

Co-authored-by: Ezequiel Rosas <nhtzr.rg@gmail.com>
Co-authored-by: Ian Glen <ian@ianglen.me>
CrossNox added a commit that referenced this pull request Jan 30, 2023
* force mistune to version 0.8.4 (#43)

closes #42 
closes #40

* pin

* Remove calls to ErrorString and SafeString removed in docutils 0.19 (#49)

* remove python2

* fix pipelines

* fix linter pipeline

* set language for sphinx

* fix tests pipeline

* fix pipeline, set docutiles dependency

* why did I change this

* bump

* Added python_requires to setup.py (#56)

* fix quotes

---------

Co-authored-by: Ezequiel Rosas <nhtzr.rg@gmail.com>
Co-authored-by: Ian Glen <ian@ianglen.me>
Co-authored-by: Martin Pecka <peci1@seznam.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants