Convert addon to use template tag #84
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'ember-headless-form': patch | ||
| --- | ||
|
|
||
| Convert addon to use template tag |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. I love seeing these components in a single file! This is great. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| import { hash } from '@ember/helper'; | ||
|
|
||
| import { uniqueId } from '../../utils'; | ||
| import HeadlessFormControlRadioGroupLabelComponent from './radio-group/label'; | ||
| import HeadlessFormControlRadioComponent from './radio-group/radio'; | ||
|
|
||
| import type { TemplateOnlyComponent } from '@ember/component/template-only'; | ||
| import type { WithBoundArgs } from '@glint/template'; | ||
|
|
||
| export interface HeadlessFormControlRadioGroupComponentSignature { | ||
| Element: HTMLDivElement; | ||
| Args: { | ||
| // the following are private arguments curried by the component helper, so users will never have to use those | ||
|
There was a problem hiding this comment. ah, I like this comment and the |
||
|
|
||
| /* | ||
| * @internal | ||
| */ | ||
| name: string; | ||
|
|
||
| /* | ||
| * @internal | ||
| */ | ||
| selected: string; | ||
|
|
||
| /* | ||
| * @internal | ||
| */ | ||
| setValue: (value: string) => void; | ||
|
|
||
| /* | ||
| * @internal | ||
| */ | ||
| invalid: boolean; | ||
|
|
||
| /* | ||
| * @internal | ||
| */ | ||
| errorId: string; | ||
| }; | ||
| Blocks: { | ||
| default: [ | ||
| { | ||
| /** | ||
| * Yielded component that renders the `<input type="radio">` element. | ||
| */ | ||
| Radio: WithBoundArgs< | ||
| typeof HeadlessFormControlRadioComponent, | ||
| 'name' | 'selected' | 'setValue' | ||
| >; | ||
|
|
||
| Label: WithBoundArgs< | ||
| typeof HeadlessFormControlRadioGroupLabelComponent, | ||
| 'id' | ||
| >; | ||
| } | ||
| ]; | ||
| }; | ||
| } | ||
|
|
||
| const HeadlessFormControlRadioGroupComponent: TemplateOnlyComponent<HeadlessFormControlRadioGroupComponentSignature> = | ||
| <template> | ||
| {{#let (uniqueId) as |labelId|}} | ||
| <div | ||
| role="radiogroup" | ||
| aria-labelledby={{labelId}} | ||
| aria-invalid={{if @invalid "true"}} | ||
| aria-describedby={{if @invalid @errorId}} | ||
| ...attributes | ||
| > | ||
| {{yield | ||
| (hash | ||
| Radio=(component | ||
| HeadlessFormControlRadioComponent | ||
| name=@name | ||
| selected=@selected | ||
| setValue=@setValue | ||
| ) | ||
| Label=(component | ||
| HeadlessFormControlRadioGroupLabelComponent id=labelId | ||
| ) | ||
| ) | ||
| }} | ||
| </div> | ||
| {{/let}} | ||
| </template>; | ||
|
|
||
| export default HeadlessFormControlRadioGroupComponent; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import type { TemplateOnlyComponent } from '@ember/component/template-only'; | ||
|
|
||
| export interface HeadlessFormControlRadioGroupLabelComponentSignature { | ||
| Element: HTMLDivElement; | ||
| Args: { | ||
| // the following are private arguments curried by the component helper, so users will never have to use those | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| id: string; | ||
| }; | ||
| Blocks: { | ||
| default: []; | ||
| }; | ||
| } | ||
|
|
||
| const HeadlessFormControlRadioGroupLabelComponent: TemplateOnlyComponent<HeadlessFormControlRadioGroupLabelComponentSignature> = | ||
| <template><div id={{@id}} ...attributes>{{yield}}</div></template>; | ||
|
|
||
| export default HeadlessFormControlRadioGroupLabelComponent; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised to see double quotes here, as we're now (sort of) in JS, and they were single quotes in the hbs... 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, didn't realise this before. Probably our prettier config is a bit inconsistent. I did wonder why we have single quotes in hbs before (which in other projects were usually double quotes)...