Add basic limiting & ordering to payments API #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 awesome :) Would be cool to be able to pass in an offset param for pagination as well! (As an aside, we don't have a wrapper object for the returned resource that we could add a total "result_count" attribute to, but that would also break backwards compatibility for current API consumers. ) |
liuhenry
added a commit
that referenced
this pull request
Jan 31, 2014
Add basic limiting & ordering to payments API
|
Sounds good. We could use the Link HTTP header for a backwards compatible next/previous pagination (if we care enough). http://tools.ietf.org/html/rfc5988#page-6 At this point instead of limit/offset it might be worth it just to pull in a pagination gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.